Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#197): --version, -v #198

Merged
merged 3 commits into from
Oct 9, 2024
Merged

feat(#197): --version, -v #198

merged 3 commits into from
Oct 9, 2024

Conversation

h1alexbel
Copy link
Owner

@h1alexbel h1alexbel commented Oct 9, 2024

closes #197


PR-Codex overview

This PR enhances the fakehub CLI by adding version output tests and modifying the argument parser to include a version flag.

Detailed summary

  • Added a test function outputs_version to check the output of the --version flag.
  • Added a test function outputs_version_from_short to check the output of the -v flag.
  • Updated the Args struct to include a version argument with ArgAction::Version.
  • Modified the command attribute to include the version in the command metadata.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.69%. Comparing base (c513ad7) to head (d75e415).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #198   +/-   ##
=======================================
  Coverage   74.69%   74.69%           
=======================================
  Files          20       20           
  Lines         328      328           
=======================================
  Hits          245      245           
  Misses         83       83           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@h1alexbel
Copy link
Owner Author

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Oct 9, 2024

@rultor merge

@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here.

@rultor rultor merged commit d75e415 into master Oct 9, 2024
14 checks passed
@rultor
Copy link
Collaborator

rultor commented Oct 9, 2024

@rultor merge

@h1alexbel Done! FYI, the full log is here (took me 15min).

@h1alexbel h1alexbel deleted the 197 branch October 9, 2024 10:04
@h1alexbel
Copy link
Owner Author

@rultor release, tag is 0.0.10

@rultor
Copy link
Collaborator

rultor commented Oct 9, 2024

@rultor release, tag is 0.0.10

@h1alexbel OK, I will release it now. Please check the progress here.

@rultor
Copy link
Collaborator

rultor commented Oct 9, 2024

@rultor release, tag is 0.0.10

@h1alexbel Done! FYI, the full log is here (took me 19min).

@0crat
Copy link

0crat commented Oct 9, 2024

@h1alexbel Great work on your contribution! 🌟 You've earned +4 points: +4 base, -16 for missing code review, -4 for minimal comments, +20 bonus. We appreciate your effort! Keep the momentum going. Your current balance is +35. Looking forward to your next submission!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fakehub does not have --version argument
4 participants